When I upgrade to DEVONthink 4, do I trade-in my license?

No, all license codes for DEVONthink 3 remain valid and you do not need a new, separate license for DEVONthink 4.